Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 775bf277 authored by Stephen M. Cameron's avatar Stephen M. Cameron Committed by James Bottomley
Browse files

[SCSI] hpsa: do not sleep in atomic context in rmmod path. 



Don't call kthread_stop with a spin lock held and interrupts
disabled because kthread_stop will sleep waiting for the thread
to stop.

Signed-off-by: default avatarStephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent f2d7e40e

drivers/scsi/hpsa.c

+2 −0
Original line number Diff line number Diff line
@@ -4271,7 +4271,9 @@ static void stop_controller_lockup_detector(struct ctlr_info *h) 
	remove_ctlr_from_lockup_detector_list(h);

	/* If the list of ctlr's to monitor is empty, stop the thread */

	if (list_empty(&hpsa_ctlr_list)) {

		spin_unlock_irqrestore(&lockup_detector_lock, flags);

		kthread_stop(hpsa_lockup_detector);

		spin_lock_irqsave(&lockup_detector_lock, flags);

		hpsa_lockup_detector = NULL;

	}

	spin_unlock_irqrestore(&lockup_detector_lock, flags);