Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77418921 authored by Thomas Meyer's avatar Thomas Meyer Committed by Tony Luck
Browse files

efi, pstore: Cocci spatch "memdup.spatch" 



Change a kmalloc() + memcpy() pair for a single kmemdup() call.

Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent d683b96b

drivers/firmware/efi/efi-pstore.c

+1 −2
Original line number Diff line number Diff line
@@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct efivar_entry *entry, void *data) 
			   &entry->var.DataSize, entry->var.Data);

	size = entry->var.DataSize;



	*cb_data->buf = kmalloc(size, GFP_KERNEL);

	*cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL);

	if (*cb_data->buf == NULL)

		return -ENOMEM;

	memcpy(*cb_data->buf, entry->var.Data, size);

	return size;

}