Commit 7717d983 authored Jan 05, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Dec 05, 2019

tipc: fix memory leak in tipc_nl_compat_publ_dump



[ Upstream commit f87d8ad9233f115db92c6c087d58403b0009ed36 ]

There is a memory leak in case genlmsg_put fails.

Fix this by freeing *args* before return.

Addresses-Coverity-ID: 1476406 ("Resource leak")
Fixes: 46273cf7e009 ("tipc: fix a missing check of genlmsg_put")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5c4c8e4f

net/tipc/netlink_compat.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -983,8 +983,10 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock)

		hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI,
		TIPC_NL_PUBL_GET);
		if (!hdr)
		if (!hdr) {
		kfree_skb(args);
		return -EMSGSIZE;
		}

		nest = nla_nest_start(args, TIPC_NLA_SOCK);
		if (!nest) {