Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76ec01db authored by Grant Likely's avatar Grant Likely Committed by Benjamin Herrenschmidt
Browse files

powerpc/pci: Fix checking for child bridges in PCI code. 



pci_device_to_OF_node() can return null, and list_for_each_entry will
never enter the loop when dev is NULL, so it looks like this test is
a typo.

Reported-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent c686ecf5

arch/powerpc/kernel/pci_of_scan.c

+2 −1
Original line number Diff line number Diff line
@@ -336,6 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node, 
		if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||

		    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) {

			struct device_node *child = pci_device_to_OF_node(dev);

			if (child)

				of_scan_pci_bridge(child, dev);

		}

	}