Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76119125 authored by Stefano Stabellini's avatar Stefano Stabellini Committed by Juergen Gross
Browse files

pvcalls-back: do not return error on inet_accept EAGAIN 



When the client sends a regular blocking accept request, the backend is
expected to return only when the accept is completed, simulating a
blocking behavior, or return an error.

Specifically, on EAGAIN from inet_accept, the backend shouldn't return
"EAGAIN" to the client. Instead, it should simply continue the wait.
Otherwise, the client will send another accept request, which will cause
another EAGAIN to be sent back, which is a waste of resources and not
conforming to the expected behavior. Change the behavior by turning the
"goto error" into a return.

Signed-off-by: default avatarStefano Stabellini <stefano@aporeto.com>
Reviewed-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent f599c64f

drivers/xen/pvcalls-back.c

+1 −1
Original line number Diff line number Diff line
@@ -548,7 +548,7 @@ static void __pvcalls_back_accept(struct work_struct *work) 
	ret = inet_accept(mappass->sock, sock, O_NONBLOCK, true);

	if (ret == -EAGAIN) {

		sock_release(sock);

		goto out_error;

		return;

	}



	map = pvcalls_new_active_socket(fedata,