Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 760f6aac authored Nov 23, 2020 by Praveen Kurapati

msm: ipa3: Add check to validate rule_cnt



Add proper check to validate table rule count
which may lead to overflow error.

Change-Id: I9bdcafcaae4e4cff1b901929c8dc6ae804f85642
Signed-off-by: Praveen Kurapati <pkurapat@codeaurora.org>

parent 342d96d9

drivers/platform/msm/ipa/ipa_v3/ipa_flt.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -939,7 +939,10 @@ static int __ipa_finish_flt_rule_add(struct ipa3_flt_tbl *tbl,
		{
		int id;

		if (tbl->rule_cnt < IPA_RULE_CNT_MAX)
		tbl->rule_cnt++;
		else
		return -EINVAL;
		if (entry->rt_tbl)
		entry->rt_tbl->ref_cnt++;
		id = ipa3_id_alloc(entry);

drivers/platform/msm/ipa/ipa_v3/ipa_i.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -457,6 +457,8 @@ enum {

		#define MBOX_TOUT_MS 100

		#define IPA_RULE_CNT_MAX 512

		struct ipa3_active_client_htable_entry {
		struct hlist_node list;
		char id_string[IPA3_ACTIVE_CLIENTS_LOG_NAME_LEN];

drivers/platform/msm/ipa/ipa_v3/ipa_rt.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1077,7 +1077,10 @@ static int __ipa_finish_rt_rule_add(struct ipa3_rt_entry entry, u32 rule_hdl,
		{
		int id;

		if (tbl->rule_cnt < IPA_RULE_CNT_MAX)
		tbl->rule_cnt++;
		else
		return -EINVAL;
		if (entry->hdr)
		entry->hdr->ref_cnt++;
		else if (entry->proc_ctx)