Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75d68369 authored by Himanshu Jha's avatar Himanshu Jha Committed by Herbert Xu
Browse files

crypto: Use zeroing memory allocator instead of allocator/memset 



Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Signed-off-by: default avatarHimanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b7dac373

drivers/crypto/amcc/crypto4xx_core.c

+3 −5
Original line number Diff line number Diff line
@@ -282,14 +282,12 @@ static u32 crypto4xx_put_pd_to_pdr(struct crypto4xx_device *dev, u32 idx) 
 */

static u32 crypto4xx_build_gdr(struct crypto4xx_device *dev)

{

	dev->gdr = dma_alloc_coherent(dev->core_dev->device,

	dev->gdr = dma_zalloc_coherent(dev->core_dev->device,

				       sizeof(struct ce_gd) * PPC4XX_NUM_GD,

				       &dev->gdr_pa, GFP_ATOMIC);

	if (!dev->gdr)

		return -ENOMEM;



	memset(dev->gdr, 0, sizeof(struct ce_gd) * PPC4XX_NUM_GD);



	return 0;

}

drivers/crypto/ixp4xx_crypto.c

+3 −4
Original line number Diff line number Diff line
@@ -260,12 +260,11 @@ static int setup_crypt_desc(void) 
{

	struct device *dev = &pdev->dev;

	BUILD_BUG_ON(sizeof(struct crypt_ctl) != 64);

	crypt_virt = dma_alloc_coherent(dev,

	crypt_virt = dma_zalloc_coherent(dev,

					 NPE_QLEN * sizeof(struct crypt_ctl),

					 &crypt_phys, GFP_ATOMIC);

	if (!crypt_virt)

		return -ENOMEM;

	memset(crypt_virt, 0, NPE_QLEN * sizeof(struct crypt_ctl));

	return 0;

}