tracing/blktrace: Fix to allow setting same value
Masami Hiramatsu reported:
  Current trace-enable attribute in sysfs returns an error
  if user writes the same setting value as current one,
  e.g.
    # cat /sys/block/sda/trace/enable
    0
    # echo 0 > /sys/block/sda/trace/enable
    bash: echo: write error: Invalid argument
    # echo 1 > /sys/block/sda/trace/enable
    # echo 1 > /sys/block/sda/trace/enable
    bash: echo: write error: Device or resource busy
  But this is not a preferred behavior, it should ignore
  if new setting is same as current one. This fixes the
  problem as below.
    # cat /sys/block/sda/trace/enable
    0
    # echo 0 > /sys/block/sda/trace/enable
    # echo 1 > /sys/block/sda/trace/enable
    # echo 1 > /sys/block/sda/trace/enable
Link: http://lkml.kernel.org/r/20180816103802.08678002@gandalf.local.home
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Cc: stable@vger.kernel.org
Fixes: cd649b8b ("blktrace: remove sysfs_blk_trace_enable_show/store()")
Reported-by:  Masami Hiramatsu <mhiramat@kernel.org>
Tested-by:
Masami Hiramatsu <mhiramat@kernel.org>
Tested-by:  Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by:
Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by:  Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by:
Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by:  Jens Axboe <axboe@kernel.dk>
Jens Axboe <axboe@kernel.dk>
Loading
Please register or sign in to comment
