Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7576750f authored by Thilo Cestonaro's avatar Thilo Cestonaro Committed by Guenter Roeck
Browse files

hwmon: (ftsteutates) Fix clearing alarm sysfs entries 



sysfs store functions should return the number of bytes written.
Returning zero results in an endless loop.

Fixes: 08426eda ("hwmon: Add driver for FTS BMC chip "Teutates"")
Signed-off-by: default avatarThilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
[groeck: Clean up documentation change and description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent aae4e7a8

Documentation/hwmon/ftsteutates

+4 −0
Original line number Diff line number Diff line
@@ -18,6 +18,10 @@ enhancements. It can monitor up to 4 voltages, 16 temperatures and 
8 fans. It also contains an integrated watchdog which is currently

implemented in this driver.



To clear a temperature or fan alarm, execute the following command with the

correct path to the alarm file:

	echo 0 >XXXX_alarm



Specification of the chip can be found here:

ftp://ftp.ts.fujitsu.com/pub/Mainboard-OEM-Sales/Services/Software&Tools/Linux_SystemMonitoring&Watchdog&GPIO/BMC-Teutates_Specification_V1.21.pdf

ftp://ftp.ts.fujitsu.com/pub/Mainboard-OEM-Sales/Services/Software&Tools/Linux_SystemMonitoring&Watchdog&GPIO/Fujitsu_mainboards-1-Sensors_HowTo-en-US.pdf

drivers/hwmon/ftsteutates.c

+2 −0
Original line number Diff line number Diff line
@@ -435,6 +435,7 @@ clear_temp_alarm(struct device *dev, struct device_attribute *devattr, 
		goto error;



	data->valid = false;

	ret = count;

error:

	mutex_unlock(&data->update_lock);

	return ret;
@@ -508,6 +509,7 @@ clear_fan_alarm(struct device *dev, struct device_attribute *devattr, 
		goto error;



	data->valid = false;

	ret = count;

error:

	mutex_unlock(&data->update_lock);

	return ret;