Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 753dfd23 authored by Wei Yongjun's avatar Wei Yongjun Committed by Peter Chen
Browse files

usb: chipidea: msm: Fix return value check in ci_hdrc_msm_probe() 



In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 2fc305be ("usb: chipidea: msm: Mux over secondary phy at the
right time")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarStephen Boyd <stephen.boyd@linaro.org>
Signed-off-by: default avatarPeter Chen <peter.chen@nxp.com>
parent 490b63e6

drivers/usb/chipidea/ci_hdrc_msm.c

+2 −2
Original line number Diff line number Diff line
@@ -218,8 +218,8 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) 


	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);

	ci->base = devm_ioremap_resource(&pdev->dev, res);

	if (!ci->base)

		return -ENOMEM;

	if (IS_ERR(ci->base))

		return PTR_ERR(ci->base);



	ci->rcdev.owner = THIS_MODULE;

	ci->rcdev.ops = &ci_hdrc_msm_reset_ops;