Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75362a3f authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops. 



Returning 0 for doing nothing is confusing to the user.

Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent efb15c39

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -961,7 +961,7 @@ static int bnxt_set_pauseparam(struct net_device *dev, 
	struct bnxt_link_info *link_info = &bp->link_info;



	if (!BNXT_SINGLE_PF(bp))

		return rc;

		return -EOPNOTSUPP;



	if (epause->autoneg) {

		if (!(link_info->autoneg & BNXT_AUTONEG_SPEED))
@@ -1483,7 +1483,7 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata) 
	int rc = 0;



	if (!BNXT_SINGLE_PF(bp))

		return 0;

		return -EOPNOTSUPP;



	if (!(bp->flags & BNXT_FLAG_EEE_CAP))

		return -EOPNOTSUPP;