Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7534122d authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: cx18: remove redundant zero check on retval 



The check for a zero retval is redundant as all paths that lead to
this point have set retval to an error return value that is non-zero.
Remove the redundant check.

Detected by CoverityScan, CID#102589 ("Logically dead code")

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 34dbb848

drivers/media/pci/cx18/cx18-driver.c

+0 −2
Original line number Diff line number Diff line
@@ -1134,8 +1134,6 @@ static int cx18_probe(struct pci_dev *pci_dev, 
free_workqueues:

	destroy_workqueue(cx->in_work_queue);

err:

	if (retval == 0)

		retval = -ENODEV;

	CX18_ERR("Error %d on initialization\n", retval);



	v4l2_device_unregister(&cx->v4l2_dev);