Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 743115ee authored by Jonathan Corbet's avatar Jonathan Corbet
Browse files

i2o: fasync BKL pushdown 



This driver appears to really need the BKL to protect open_files.

Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
parent b7e3e1fb

drivers/message/i2o/i2o_config.c

+6 −4
Original line number Diff line number Diff line
@@ -1084,15 +1084,17 @@ static int cfg_fasync(int fd, struct file *fp, int on) 
{

	ulong id = (ulong) fp->private_data;

	struct i2o_cfg_info *p;

	int ret = -EBADF;



	lock_kernel();

	for (p = open_files; p; p = p->next)

		if (p->q_id == id)

			break;



	if (!p)

		return -EBADF;



	return fasync_helper(fd, fp, on, &p->fasync);

	if (p)

		ret = fasync_helper(fd, fp, on, &p->fasync);

	unlock_kernel();

	return ret;

}



static int cfg_release(struct inode *inode, struct file *file)