Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7429b384 authored by Wolfram Sang's avatar Wolfram Sang Committed by Benjamin Herrenschmidt
Browse files

powerpc/pmac: Fix dangling pointers 



Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.

Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Cc: Colin Leroy <colin@colino.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 21dbeb91

drivers/macintosh/therm_adt746x.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -182,6 +182,7 @@ remove_thermostat(struct i2c_client *client) 




	thermostat = NULL;

	thermostat = NULL;





	i2c_set_clientdata(client, NULL);

	kfree(th);

	kfree(th);





	return 0;

	return 0;
@@ -399,6 +400,7 @@ static int probe_thermostat(struct i2c_client *client, 
	rc = read_reg(th, CONFIG_REG);

	rc = read_reg(th, CONFIG_REG);

	if (rc < 0) {

	if (rc < 0) {

		dev_err(&client->dev, "Thermostat failed to read config!\n");

		dev_err(&client->dev, "Thermostat failed to read config!\n");

		i2c_set_clientdata(client, NULL);

		kfree(th);

		kfree(th);

		return -ENODEV;

		return -ENODEV;

	}

	}