Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74142ffc authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: max77686: Fix regmap resource leak on driver remove 



The regmap used by max77686 MFD driver was not freed with regmap_exit()
on driver exit. This lead to leak of resources.

Replace regmap_init_i2c() call in driver probe with initialization of
managed register map so the regmap will be properly freed by the device
management code.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent f876a975

drivers/mfd/max77686.c

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ static int max77686_i2c_probe(struct i2c_client *i2c, 
	max77686->irq_gpio = pdata->irq_gpio;

	max77686->irq = i2c->irq;



	max77686->regmap = regmap_init_i2c(i2c, &max77686_regmap_config);

	max77686->regmap = devm_regmap_init_i2c(i2c, &max77686_regmap_config);

	if (IS_ERR(max77686->regmap)) {

		ret = PTR_ERR(max77686->regmap);

		dev_err(max77686->dev, "Failed to allocate register map: %d\n",