Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73ec513a authored by Venkatraman S's avatar Venkatraman S Committed by James Bottomley
Browse files

[SCSI] ufs: reverse the ufshcd_is_device_present logic 



Otherwise it counter intuitively returns 0 if device is present.

Signed-off-by: default avatarVenkatraman S <svenkatr@ti.com>
Reviewed-by: default avatarNamjae Jeon <linkinjeon@gmail.com>
Acked-by: default avatarSantosh Y <santoshsy@gmail.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 17ccafc4

drivers/scsi/ufs/ufshcd.c

+3 −3
Original line number Diff line number Diff line
@@ -232,11 +232,11 @@ static inline u32 ufshcd_get_ufs_version(struct ufs_hba *hba) 
 *			      the host controller

 * @reg_hcs - host controller status register value

 *

 * Returns 0 if device present, non-zero if no device detected

 * Returns 1 if device present, 0 if no device detected

 */

static inline int ufshcd_is_device_present(u32 reg_hcs)

{

	return (DEVICE_PRESENT & reg_hcs) ? 0 : -1;

	return (DEVICE_PRESENT & reg_hcs) ? 1 : 0;

}



/**
@@ -911,7 +911,7 @@ static int ufshcd_make_hba_operational(struct ufs_hba *hba) 


	/* check if device present */

	reg = readl((hba->mmio_base + REG_CONTROLLER_STATUS));

	if (ufshcd_is_device_present(reg)) {

	if (!ufshcd_is_device_present(reg)) {

		dev_err(&hba->pdev->dev, "cc: Device not present\n");

		err = -ENXIO;

		goto out;