Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73e1c093 authored by Andreas Larsson's avatar Andreas Larsson Committed by Felipe Balbi
Browse files

usb: gadget: gr_udc: Use of_property_read_u32_index to access arrays 



Use an appropriate accessor function for property arrays to make the code nicer
and make the code correct if it would ever run on little endian architectures.
Suggested by Mark Rutland.

Signed-off-by: default avatarAndreas Larsson <andreas@gaisler.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 196800da

drivers/usb/gadget/gr_udc.c

+4 −8
Original line number Diff line number Diff line
@@ -2020,9 +2020,7 @@ static int gr_udc_init(struct gr_udc *dev) 
	u32 dmactrl_val;

	int i;

	int ret = 0;

	u32 *bufsizes;

	u32 bufsize;

	int len;



	gr_set_address(dev, 0);
@@ -2033,19 +2031,17 @@ static int gr_udc_init(struct gr_udc *dev) 
	INIT_LIST_HEAD(&dev->ep_list);

	gr_set_ep0state(dev, GR_EP0_DISCONNECT);



	bufsizes = (u32 *)of_get_property(np, "epobufsizes", &len);

	len /= sizeof(u32);

	for (i = 0; i < dev->nepo; i++) {

		bufsize = (bufsizes && i < len) ? bufsizes[i] : 1024;

		if (of_property_read_u32_index(np, "epobufsizes", i, &bufsize))

			bufsize = 1024;

		ret = gr_ep_init(dev, i, 0, bufsize);

		if (ret)

			return ret;

	}



	bufsizes = (u32 *)of_get_property(np, "epibufsizes", &len);

	len /= sizeof(u32);

	for (i = 0; i < dev->nepi; i++) {

		bufsize = (bufsizes && i < len) ? bufsizes[i] : 1024;

		if (of_property_read_u32_index(np, "epibufsizes", i, &bufsize))

			bufsize = 1024;

		ret = gr_ep_init(dev, i, 1, bufsize);

		if (ret)

			return ret;