Commit 735a0045 authored Jan 15, 2017 by Goodstein, Mordechay Committed by Luca Coelho Feb 08, 2017

iwlwifi: mvm: avoid race condition in ADD_STA.



The race happens when we send ADD_STA(auth->assoc) -> LQ_CMD
between the commands the FW sometimes loses the medium for AUX, and
sends a ndp to the AP and the flow becomes, ADD_STA -> send ndp -> LQ_CMD
the problem is that there's no rates yet defined for sending the ndp and
FW generates an assert.

The fix: change the order of the commands to LQ_CMD -> ADD_STA

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent b45242c9

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -2627,11 +2627,10 @@ static int iwl_mvm_mac_sta_state(struct ieee80211_hw *hw,
		mvmvif->ap_assoc_sta_count++;
		iwl_mvm_mac_ctxt_changed(mvm, vif, false, NULL);
		}
		ret = iwl_mvm_update_sta(mvm, vif, sta);
		if (ret == 0)
		iwl_mvm_rs_rate_init(mvm, sta,
		mvmvif->phy_ctxt->channel->band,

		iwl_mvm_rs_rate_init(mvm, sta, mvmvif->phy_ctxt->channel->band,
		true);
		ret = iwl_mvm_update_sta(mvm, vif, sta);
		} else if (old_state == IEEE80211_STA_ASSOC &&
		new_state == IEEE80211_STA_AUTHORIZED) {