Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72dca06f authored by Aniroop Mathur's avatar Aniroop Mathur Committed by Mark Brown
Browse files

regulator: core: Avoid negative regulator no & initialize it to -1 



This patch initializes regulator_no to -1 to avoid extra subtraction
operation performed every time we register a regulator and avoid negative
regulator no in its name.

Signed-off-by: default avatarAniroop Mathur <a.mathur@samsung.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 97bf6af1

drivers/regulator/core.c

+3 −3
Original line number Diff line number Diff line
@@ -3585,7 +3585,7 @@ regulator_register(const struct regulator_desc *regulator_desc, 
{

	const struct regulation_constraints *constraints = NULL;

	const struct regulator_init_data *init_data;

	static atomic_t regulator_no = ATOMIC_INIT(0);

	static atomic_t regulator_no = ATOMIC_INIT(-1);

	struct regulator_dev *rdev;

	struct device *dev;

	int ret, i;
@@ -3658,8 +3658,8 @@ regulator_register(const struct regulator_desc *regulator_desc, 
	/* register with sysfs */

	rdev->dev.class = &regulator_class;

	rdev->dev.parent = dev;

	dev_set_name(&rdev->dev, "regulator.%d",

		     atomic_inc_return(&regulator_no) - 1);

	dev_set_name(&rdev->dev, "regulator.%lu",

		     atomic_inc_return(&regulator_no));

	ret = device_register(&rdev->dev);

	if (ret != 0) {

		put_device(&rdev->dev);