Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71b2c87d authored by Colin Ian King's avatar Colin Ian King Committed by Alexei Starovoitov
Browse files

bpf: devmap: remove redundant assignment of dev = dev 



The assignment dev = dev is redundant and should be removed.

Detected by CoverityScan, CID#1469486 ("Evaluation order violation")

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarSong Liu <songliubraving@fb.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 13a370b9

kernel/bpf/devmap.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -352,7 +352,7 @@ int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp, 
static void *dev_map_lookup_elem(struct bpf_map *map, void *key)

static void *dev_map_lookup_elem(struct bpf_map *map, void *key)

{

{

	struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);

	struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);

	struct net_device *dev = dev = obj ? obj->dev : NULL;

	struct net_device *dev = obj ? obj->dev : NULL;





	return dev ? &dev->ifindex : NULL;

	return dev ? &dev->ifindex : NULL;

}

}