Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71423274 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: clean up bad-type check in nfsd_create_locked 



Minor cleanup, no change in behavior.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent d03d9fe4

fs/nfsd/vfs.c

+4 −7
Original line number Diff line number Diff line
@@ -1166,13 +1166,6 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp, 
		iap->ia_mode = 0;

	iap->ia_mode = (iap->ia_mode & S_IALLUGO) | type;



	err = nfserr_inval;

	if (!S_ISREG(type) && !S_ISDIR(type) && !special_file(type)) {

		printk(KERN_WARNING "nfsd: bad file type %o in nfsd_create\n",

		       type);

		goto out;

	}



	err = 0;

	host_err = 0;

	switch (type) {
@@ -1190,6 +1183,10 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp, 
	case S_IFSOCK:

		host_err = vfs_mknod(dirp, dchild, iap->ia_mode, rdev);

		break;

	default:

		printk(KERN_WARNING "nfsd: bad file type %o in nfsd_create\n",

		       type);

		host_err = -EINVAL;

	}

	if (host_err < 0)

		goto out_nfserr;