Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70dc6daf authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

regulator: core: remove some dead code 



Originally queue_delayed_work() used to negative error codes or 0 and 1
on success depending if the work was queued or not.  It caused a lot of
bugs where people treated all non-zero returns as failures so we changed
it to return bool instead in d4283e93 ('workqueue: make queueing
functions return bool').  Now it never returns failure.

Checking for negative values causes a static checker warning since it is
impossible based on the bool type.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 83080a14

drivers/regulator/core.c

+3 −8
Original line number Diff line number Diff line
@@ -2368,7 +2368,6 @@ static void regulator_disable_work(struct work_struct *work) 
int regulator_disable_deferred(struct regulator *regulator, int ms)

{

	struct regulator_dev *rdev = regulator->rdev;

	int ret;



	if (regulator->always_on)

		return 0;
@@ -2380,12 +2379,8 @@ int regulator_disable_deferred(struct regulator *regulator, int ms) 
	rdev->deferred_disables++;

	mutex_unlock(&rdev->mutex);



	ret = queue_delayed_work(system_power_efficient_wq,

				 &rdev->disable_work,

	queue_delayed_work(system_power_efficient_wq, &rdev->disable_work,

			   msecs_to_jiffies(ms));

	if (ret < 0)

		return ret;

	else

	return 0;

}

EXPORT_SYMBOL_GPL(regulator_disable_deferred);