Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70998b99 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: multiq3: use comedi_request_region() 



Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4aa83c19

drivers/staging/comedi/drivers/multiq3.c

+7 −13
Original line number Diff line number Diff line
@@ -226,22 +226,16 @@ static int multiq3_attach(struct comedi_device *dev, 
			  struct comedi_devconfig *it)

{

	struct multiq3_private *devpriv;

	int result = 0;

	unsigned long iobase;

	struct comedi_subdevice *s;

	int ret;



	iobase = it->options[0];

	printk(KERN_INFO "comedi%d: multiq3: 0x%04lx ", dev->minor, iobase);

	if (!request_region(iobase, MULTIQ3_SIZE, "multiq3")) {

		printk(KERN_ERR "comedi%d: I/O port conflict\n", dev->minor);

		return -EIO;

	}



	dev->iobase = iobase;

	ret = comedi_request_region(dev, it->options[0], MULTIQ3_SIZE);

	if (ret)

		return ret;



	result = comedi_alloc_subdevices(dev, 5);

	if (result)

		return result;

	ret = comedi_alloc_subdevices(dev, 5);

	if (ret)

		return ret;



	devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL);

	if (!devpriv)