Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 700aa7ff authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Felipe Balbi
Browse files

usb: renesas_usbhs: Use dmac only if the pipe type is bulk 



This patch fixes an issue that isochronous transfer's data is possible to
be lost as a workaround. Since this driver uses a workqueue to start
the dmac, the transfer is possible to be delayed when system load is high.

Fixes: 6e4b74e4 ("usb: renesas: fix scheduling in atomic context bug")
Cc: <stable@vger.kernel.org> # v3.4+
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 9ab967e6

drivers/usb/renesas_usbhs/fifo.c

+2 −2
Original line number Diff line number Diff line
@@ -871,7 +871,7 @@ static int usbhsf_dma_prepare_push(struct usbhs_pkt *pkt, int *is_done) 


	/* use PIO if packet is less than pio_dma_border or pipe is DCP */

	if ((len < usbhs_get_dparam(priv, pio_dma_border)) ||

	    usbhs_pipe_is_dcp(pipe))

	    usbhs_pipe_type_is(pipe, USB_ENDPOINT_XFER_ISOC))

		goto usbhsf_pio_prepare_push;



	/* check data length if this driver don't use USB-DMAC */
@@ -976,7 +976,7 @@ static int usbhsf_dma_prepare_pop_with_usb_dmac(struct usbhs_pkt *pkt, 


	/* use PIO if packet is less than pio_dma_border or pipe is DCP */

	if ((pkt->length < usbhs_get_dparam(priv, pio_dma_border)) ||

	    usbhs_pipe_is_dcp(pipe))

	    usbhs_pipe_type_is(pipe, USB_ENDPOINT_XFER_ISOC))

		goto usbhsf_pio_prepare_pop;



	fifo = usbhsf_get_dma_fifo(priv, pkt);