Commit 6fdc31a2 authored Aug 12, 2009 by Bastian Blank Committed by Benjamin Herrenschmidt Aug 27, 2009

powerpc: Remove SMP warning from PowerMac cpufreq



On Thu, Aug 13, 2009 at 04:14:58PM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2009-08-11 at 11:39 +0200, Bastian Blank wrote:
> > This patch just disables this driver on SMP kernels, as it is obviously
> > not supported.
> Why not remove the #error instead ? :-) I don't think it's still
> meaningful, especially since we use the timebase for delays nowadays
> which doesn't depend on the CPU frequency...

Your call. Take this one:

The build of a PowerMac 32bit kernel currently fails with

error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"

Thie patch removes the not longer applicable SMP warning from the
PowerMac cpufreq code.

Signed-off-by: Bastian Blank <waldi@debian.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

parent 14d75752

arch/powerpc/platforms/powermac/cpufreq_32.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -44,14 +44,6 @@
		*/
		#undef DEBUG_FREQ

		/*
		* There is a problem with the core cpufreq code on SMP kernels,
		* it won't recalculate the Bogomips properly
		*/
		#ifdef CONFIG_SMP
		#warning "WARNING, CPUFREQ not recommended on SMP kernels"
		#endif

		extern void low_choose_7447a_dfs(int dfs);
		extern void low_choose_750fx_pll(int pll);
		extern void low_sleep_handler(void);