Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f9d4722 authored Jan 20, 2006 by Eric Sesterhenn Committed by Jeff Garzik Jan 26, 2006

[PATCH] acenic: fix checking of read_eeprom_byte() return values



tmp in ace_init is u32 thus rendering read_eeprom_byte() return values
checks useless.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>

parent 6a986ce4

drivers/net/acenic.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev)

		mac1 = 0;
		for(i = 0; i < 4; i++) {
		int tmp;

		mac1 = mac1 << 8;
		tmp = read_eeprom_byte(dev, 0x8c+i);
		if (tmp < 0) {
		@@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev)
		}
		mac2 = 0;
		for(i = 4; i < 8; i++) {
		int tmp;

		mac2 = mac2 << 8;
		tmp = read_eeprom_byte(dev, 0x8c+i);
		if (tmp < 0) {