Commit 6f5d2959 authored Apr 25, 2018 by Colin Ian King Committed by David S. Miller Apr 25, 2018

mkiss: remove redundant check for len > 0



The check for len > 0 is always true and hence is redundant as
this check is already being made to execute the code inside the
while-loop. Hence it is redundant and can be removed.

Cleans up cppcheck warning:
drivers/net/hamradio/mkiss.c:220: (warning) Identical inner 'if'
condition is always true.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4d7b4483

drivers/net/hamradio/mkiss.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -217,7 +217,7 @@ static int kiss_esc_crc(unsigned char s, unsigned char d, unsigned short crc,
		c = *s++;
		else if (len > 1)
		c = crc >> 8;
		else if (len > 0)
		else
		c = crc & 0xff;

		len--;