Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f482e37 authored by Sara Sharon's avatar Sara Sharon Committed by Luca Coelho
Browse files

iwlwifi: move iwl_drv to be shared across transports 



All transports has this structure. By moving it to be
shared, we can get rid of casting to the specific transport
in probe and remove.

Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 38398efb

drivers/net/wireless/intel/iwlwifi/iwl-trans.h

+2 −0
Original line number Diff line number Diff line
@@ -761,6 +761,7 @@ enum iwl_plat_pm_mode { 
 * @ops - pointer to iwl_trans_ops

 * @op_mode - pointer to the op_mode

 * @cfg - pointer to the configuration

 * @drv - pointer to iwl_drv

 * @status: a bit-mask of transport status flags

 * @dev - pointer to struct device * that represents the device

 * @max_skb_frags: maximum number of fragments an SKB can have when transmitted.
@@ -804,6 +805,7 @@ struct iwl_trans { 
	const struct iwl_trans_ops *ops;

	struct iwl_op_mode *op_mode;

	const struct iwl_cfg *cfg;

	struct iwl_drv *drv;

	enum iwl_trans_state state;

	unsigned long status;

drivers/net/wireless/intel/iwlwifi/pcie/drv.c

+5 −9
Original line number Diff line number Diff line
@@ -610,7 +610,6 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	const struct iwl_cfg *cfg_7265d __maybe_unused = NULL;

	const struct iwl_cfg *cfg_9260lc __maybe_unused = NULL;

	struct iwl_trans *iwl_trans;

	struct iwl_trans_pcie *trans_pcie;

	int ret;



	iwl_trans = iwl_trans_pcie_alloc(pdev, ent, cfg);
@@ -648,12 +647,10 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
#endif



	pci_set_drvdata(pdev, iwl_trans);

	iwl_trans->drv = iwl_drv_start(iwl_trans, cfg);



	trans_pcie = IWL_TRANS_GET_PCIE_TRANS(iwl_trans);

	trans_pcie->drv = iwl_drv_start(iwl_trans, cfg);



	if (IS_ERR(trans_pcie->drv)) {

		ret = PTR_ERR(trans_pcie->drv);

	if (IS_ERR(iwl_trans->drv)) {

		ret = PTR_ERR(iwl_trans->drv);

		goto out_free_trans;

	}
@@ -692,7 +689,7 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	return 0;



out_free_drv:

	iwl_drv_stop(trans_pcie->drv);

	iwl_drv_stop(iwl_trans->drv);

out_free_trans:

	iwl_trans_pcie_free(iwl_trans);

	return ret;
@@ -701,7 +698,6 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
static void iwl_pci_remove(struct pci_dev *pdev)

{

	struct iwl_trans *trans = pci_get_drvdata(pdev);

	struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);



	/* if RTPM was in use, restore it to the state before probe */

	if (trans->runtime_pm_mode != IWL_PLAT_PM_MODE_DISABLED) {
@@ -712,7 +708,7 @@ static void iwl_pci_remove(struct pci_dev *pdev) 
		pm_runtime_forbid(trans->dev);

	}



	iwl_drv_stop(trans_pcie->drv);

	iwl_drv_stop(trans->drv);



	iwl_trans_pcie_free(trans);

}

drivers/net/wireless/intel/iwlwifi/pcie/internal.h

+0 −2
Original line number Diff line number Diff line
@@ -314,7 +314,6 @@ struct iwl_tso_hdr_page { 
 * @rx_pool: initial pool of iwl_rx_mem_buffer for all the queues

 * @global_table: table mapping received VID from hw to rxb

 * @rba: allocator for RX replenishing

 * @drv - pointer to iwl_drv

 * @trans: pointer to the generic transport area

 * @scd_base_addr: scheduler sram base address in SRAM

 * @scd_bc_tbls: pointer to the byte count table of the scheduler
@@ -352,7 +351,6 @@ struct iwl_trans_pcie { 
	struct iwl_rx_mem_buffer *global_table[RX_POOL_SIZE];

	struct iwl_rb_allocator rba;

	struct iwl_trans *trans;

	struct iwl_drv *drv;



	struct net_device napi_dev;