Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e7f3997 authored by kbuild test robot's avatar kbuild test robot Committed by Bartlomiej Zolnierkiewicz
Browse files

fbdev: omap2: omapfb: fix bugon.cocci warnings 



drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

 Use BUG_ON instead of a if condition followed by BUG.

Semantic patch information:
 This makes an effort to find cases where BUG() follows an if
 condition on an expression and replaces the if condition and BUG()
 with a BUG_ON having the conditional expression of the if statement
 as argument.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: 7378f114 ("media: omap2: omapfb: allow building it with COMPILE_TEST")
Signed-off-by: default avatarkbuild test robot <fengguang.wu@intel.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent cb653fe8

drivers/video/fbdev/omap2/omapfb/dss/dss_features.c

+1 −2
Original line number Diff line number Diff line
@@ -891,8 +891,7 @@ bool dss_has_feature(enum dss_feat_id id) 


void dss_feat_get_reg_field(enum dss_feat_reg_field id, u8 *start, u8 *end)

{

	if (id >= omap_current_dss_features->num_reg_fields)

		BUG();

	BUG_ON(id >= omap_current_dss_features->num_reg_fields);



	*start = omap_current_dss_features->reg_fields[id].start;

	*end = omap_current_dss_features->reg_fields[id].end;