Commit 6e522422 authored Mar 02, 2016 by Jack Morgenstein Committed by David S. Miller Mar 02, 2016

net/mlx4_core: Allow resetting VF admin mac to zero



The VF administrative mac addresses (stored in the PF driver) are
initialized to zero when the PF driver starts up.

These addresses may be modified in the PF driver through ndo calls
initiated by iproute2 or libvirt.

While we allow the PF/host to change the VF admin mac address from zero
to a valid unicast mac, we do not allow restoring the VF admin mac to
zero. We currently only allow changing this mac to a different unicast mac.

This leads to problems when libvirt scripts are used to deal with
VF mac addresses, and libvirt attempts to revoke the mac so this
host will not use it anymore.

Fix this by allowing resetting a VF administrative MAC back to zero.

Fixes: 8f7ba3ca ('net/mlx4: Add set VF mac address support')
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Reported-by: Moshe Levi <moshele@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 00ada910

drivers/net/ethernet/mellanox/mlx4/en_netdev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2245,7 +2245,7 @@ static int mlx4_en_set_vf_mac(struct net_device dev, int queue, u8 mac)
		struct mlx4_en_dev *mdev = en_priv->mdev;
		u64 mac_u64 = mlx4_mac_to_u64(mac);

		if (!is_valid_ether_addr(mac))
		if (is_multicast_ether_addr(mac))
		return -EINVAL;

		return mlx4_set_vf_mac(mdev->dev, en_priv->port, queue, mac_u64);