Commit 6e494120 authored Jan 25, 2018 by Johannes Thumshirn Committed by Christoph Hellwig Jan 25, 2018

nvme: don't free uuid pointer before printing it



Commit df351ef7 ("nvme-fabrics: fix memory leak when parsing host ID
option") fixed the leak of 'p' but in case uuid_parse() fails the memory
is freed before the error print that is using it.

Free it after printing eventual errors.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: df351ef7 ("nvme-fabrics: fix memory leak when parsing host ID option")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent ee9aebb2

drivers/nvme/host/fabrics.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -739,12 +739,13 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
		goto out;
		}
		ret = uuid_parse(p, &hostid);
		kfree(p);
		if (ret) {
		pr_err("Invalid hostid %s\n", p);
		ret = -EINVAL;
		kfree(p);
		goto out;
		}
		kfree(p);
		break;
		case NVMF_OPT_DUP_CONNECT:
		opts->duplicate_connect = true;