Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e1d1f33 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: comedi_test: ao subdevice does not support async commands 



The comedi_subdevices array is kzalloc()'d so the async command callbacks do
not need to be set to NULL when the analog output subdevice is initialized.

Also, remove the initialzation of the subdevice 'len_chanlist' since this
value is only used by the async commands. The core will default it to 1.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c50a3982

drivers/staging/comedi/drivers/comedi_test.c

+0 −4
Original line number Diff line number Diff line
@@ -413,11 +413,7 @@ static int waveform_attach(struct comedi_device *dev, 
	s->n_chan = N_CHANS;

	s->maxdata = 0xffff;

	s->range_table = &waveform_ai_ranges;

	s->len_chanlist = s->n_chan * 2;

	s->insn_write = waveform_ao_insn_write;

	s->do_cmd = NULL;

	s->do_cmdtest = NULL;

	s->cancel = NULL;



	/* Our default loopback value is just a 0V flatline */

	for (i = 0; i < s->n_chan; i++)