Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6dff5add authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller
Browse files

net: usb: pegasus: Replace mdelay() with msleep() in setup_pegasus_II() 



setup_pegasus_II() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0df125d0

drivers/net/usb/pegasus.c

+1 −1
Original line number Diff line number Diff line
@@ -1067,7 +1067,7 @@ static inline void setup_pegasus_II(pegasus_t *pegasus) 


	set_register(pegasus, Reg1d, 0);

	set_register(pegasus, Reg7b, 1);

	mdelay(100);

	msleep(100);

	if ((pegasus->features & HAS_HOME_PNA) && mii_mode)

		set_register(pegasus, Reg7b, 0);

	else