Commit 6dba5182 authored Oct 22, 2020 by Gabriel Krisman Bertazi Committed by Greg Kroah-Hartman Nov 10, 2020

blk-cgroup: Fix memleak on error path



[ Upstream commit 52abfcbd57eefdd54737fc8c2dc79d8f46d4a3e5 ]

If new_blkg allocation raced with blk_policy change and
blkg_lookup_check fails, new_blkg is leaked.

Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b8f922aa

block/blk-cgroup.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -882,6 +882,7 @@ int blkg_conf_prep(struct blkcg blkcg, const struct blkcg_policy pol,
		blkg = blkg_lookup_check(pos, pol, q);
		if (IS_ERR(blkg)) {
		ret = PTR_ERR(blkg);
		blkg_free(new_blkg);
		goto fail_unlock;
		}