Commit 6ca3f28b authored Apr 09, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman Apr 11, 2013

staging: comedi: dt2811: use comedi_request_region()



Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3871a752

drivers/staging/comedi/drivers/dt2811.c

+3 −11

Original line number	Diff line number	Diff line
		@@ -399,18 +399,10 @@ static int dt2811_attach(struct comedi_device dev, struct comedi_devconfig it)
		struct dt2811_private *devpriv;
		int ret;
		struct comedi_subdevice *s;
		unsigned long iobase;

		iobase = it->options[0];

		printk(KERN_INFO "comedi%d: dt2811:base=0x%04lx\n", dev->minor, iobase);

		if (!request_region(iobase, DT2811_SIZE, dev->board_name)) {
		printk(KERN_ERR "I/O port conflict\n");
		return -EIO;
		}

		dev->iobase = iobase;
		ret = comedi_request_region(dev, it->options[0], DT2811_SIZE);
		if (ret)
		return ret;

		#if 0
		outb(0, dev->iobase + DT2811_ADCSR);