Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c810f90 authored by Dan Carpenter's avatar Dan Carpenter Committed by Artem Bityutskiy
Browse files

mtg: docg3: potential divide by zero in doc_write_oob() 



If we set oobdelta to zero then we will either return -EINVAL or hit
a divide (modulus) by zero on the next line when we check
"(ooblen % oobdelta)".  It's better to just return -EINVAL here instead.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
parent ecfe57b7

drivers/mtd/devices/docg3.c

+1 −1
Original line number Diff line number Diff line
@@ -1440,7 +1440,7 @@ static int doc_write_oob(struct mtd_info *mtd, loff_t ofs, 
		oobdelta = mtd->ecclayout->oobavail;

		break;

	default:

		oobdelta = 0;

		return -EINVAL;

	}

	if ((len % DOC_LAYOUT_PAGE_SIZE) || (ooblen % oobdelta) ||

	    (ofs % DOC_LAYOUT_PAGE_SIZE))