Commit 6c805adf authored Jul 13, 2018 by Raju P.L.S.S.S.N Committed by Andy Gross Jul 21, 2018

drivers: qcom: rpmh: fix unwanted error check for get_tcs_of_type()

The patch fixes the bug reported by Dan Carpenter.
It removes the unnecessary err check for ‘tcs’ reported by
static checker warning:

drivers/soc/qcom/rpmh-rsc.c:111 tcs_invalidate()
warn: 'tcs' isn't an ERR_PTR
See also:
drivers/soc/qcom/rpmh-rsc.c:178 get_tcs_for_msg() warn: 'tcs' isn't
an ERR_PTR
drivers/soc/qcom/rpmh-rsc.c:180 get_tcs_for_msg() warn: 'tcs' isn't
an ERR_PTR

https://www.spinics.net/lists/linux-soc/msg04624.html



Fixes: 9a3afcfb ("drivers: qcom: rpmh-rsc: allow invalidation
of sleep/wake TCS")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Raju P.L.S.S.S.N <rplsssn@codeaurora.org>
Reviewed-by: Lina Iyer <ilina@codeaurora.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>

parent efa1c257

drivers/soc/qcom/rpmh-rsc.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -108,8 +108,6 @@ static int tcs_invalidate(struct rsc_drv *drv, int type)
		struct tcs_group *tcs;

		tcs = get_tcs_of_type(drv, type);
		if (IS_ERR(tcs))
		return PTR_ERR(tcs);

		spin_lock(&tcs->lock);
		if (bitmap_empty(tcs->slots, MAX_TCS_SLOTS)) {
		@@ -175,9 +173,9 @@ static struct tcs_group get_tcs_for_msg(struct rsc_drv drv,
		* TCSes before making an active state request.
		*/
		tcs = get_tcs_of_type(drv, type);
		if (msg->state == RPMH_ACTIVE_ONLY_STATE && IS_ERR(tcs)) {
		if (msg->state == RPMH_ACTIVE_ONLY_STATE && !tcs->num_tcs) {
		tcs = get_tcs_of_type(drv, WAKE_TCS);
		if (!IS_ERR(tcs)) {
		if (tcs->num_tcs) {
		ret = rpmh_rsc_invalidate(drv);
		if (ret)
		return ERR_PTR(ret);