Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c7fce6f authored by Sean Wang's avatar Sean Wang Committed by David S. Miller
Browse files

net: ethernet: mediatek: avoid potential invalid memory access 



Potential dangerous invalid memory might be accessed if invalid mac value
reflected from the forward port field in rxd4 caused by possible potential
hardware defects. So added a simple sanity checker to avoid the kind of
situation happening.

Signed-off-by: default avatarSean Wang <sean.wang@mediatek.com>
Acked-by: default avatarJohn Crispin <john@phrozen.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 96080f69

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+4 −0
Original line number Diff line number Diff line
@@ -947,6 +947,10 @@ static int mtk_poll_rx(struct napi_struct *napi, int budget, 
		      RX_DMA_FPORT_MASK;

		mac--;



		if (unlikely(mac < 0 || mac >= MTK_MAC_COUNT ||

			     !eth->netdev[mac]))

			goto release_desc;



		netdev = eth->netdev[mac];



		if (unlikely(test_bit(MTK_RESETTING, &eth->state)))