Commit 6c662c51 authored Apr 21, 2020 by Ronnie Sahlberg Committed by Greg Kroah-Hartman May 10, 2020

cifs: protect updating server->dstaddr with a spinlock



[ Upstream commit fada37f6f62995cc449b36ebba1220594bfe55fe ]

We use a spinlock while we are reading and accessing the destination address for a server.
We need to also use this spinlock to protect when we are modifying this address from
reconn_set_ipaddr().

Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1137dfe0

fs/cifs/connect.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -353,8 +353,10 @@ static int reconn_set_ipaddr(struct TCP_Server_Info *server)
		return rc;
		}

		spin_lock(&cifs_tcp_ses_lock);
		rc = cifs_convert_address((struct sockaddr *)&server->dstaddr, ipaddr,
		strlen(ipaddr));
		spin_unlock(&cifs_tcp_ses_lock);
		kfree(ipaddr);

		return !rc ? -1 : 0;