Commit 6c642e44 authored May 30, 2014 by zhangdianfang Committed by Sasha Levin Jul 07, 2014

tools/liblockdep: Fix comparison of a boolean value with a value of 2

Comparison of a boolean value (!__init_state) with a value of 2 (done)
as currently happens in the code is unlikely to succeed and causes
repeated initialization of the pthread function pointers.

Instead, remove boolean comparison so that we would initialize said
function pointers only once.

Ref: https://bugzilla.kernel.org/show_bug.cgi?id=76741


Cc: Jean Delvare <jdelvare@suse.de>
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Dianfang Zhang <zhangdianfang@huawei.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 7171511e

tools/lib/lockdep/preload.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -92,7 +92,7 @@ enum { none, prepare, done, } __init_state;
	static void init_preload(void);		static void init_preload(void);
	static void try_init_preload(void)		static void try_init_preload(void)
	{		{
	if (!__init_state != done)		if (__init_state != done)
	init_preload();		init_preload();
	}		}