Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c2959aa authored by Hannes Eder's avatar Hannes Eder Committed by David S. Miller
Browse files

drivers/isdn/hardware/mISDN: fix sparse warnings: make symbols static 



Fix this sparse warnings:
  drivers/isdn/hardware/mISDN/hfcpci.c:59:19: warning: symbol 'hfc_tl' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcpci.c:60:9: warning: symbol 'hfc_jiffies' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcsusb.h:201:6: warning: symbol 'conf_str' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcsusb.h:319:12: warning: symbol 'HFC_TE_LAYER1_STATES' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcsusb.h:331:12: warning: symbol 'HFC_NT_LAYER1_STATES' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcsusb.c:38:12: warning: symbol 'hfcsusb_rev' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcsusb.c:978:1: warning: symbol 'fill_isoc_urb' was not declared. Should it be static?
  drivers/isdn/hardware/mISDN/hfcsusb.c:1724:1: warning: symbol 'setup_hfcsusb' was not declared. Should it be static?

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b144023

drivers/isdn/hardware/mISDN/hfcpci.c

+2 −2
Original line number Diff line number Diff line
@@ -56,8 +56,8 @@ static const char *hfcpci_revision = "2.0"; 
static int HFC_cnt;

static uint debug;

static uint poll, tics;

struct timer_list hfc_tl;

u32	hfc_jiffies;

static struct timer_list hfc_tl;

static u32 hfc_jiffies;



MODULE_AUTHOR("Karsten Keil");

MODULE_LICENSE("GPL");

drivers/isdn/hardware/mISDN/hfcsusb.c

+3 −3
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ 
#include <linux/mISDNhw.h>

#include "hfcsusb.h"



const char *hfcsusb_rev = "Revision: 0.3.3 (socket), 2008-11-05";

static const char *hfcsusb_rev = "Revision: 0.3.3 (socket), 2008-11-05";



static unsigned int debug;

static int poll = DEFAULT_TRANSP_BURST_SZ;
@@ -974,7 +974,7 @@ hfcsusb_rx_frame(struct usb_fifo *fifo, __u8 *data, unsigned int len, 
	spin_unlock(&hw->lock);

}



void

static void

fill_isoc_urb(struct urb *urb, struct usb_device *dev, unsigned int pipe,

	      void *buf, int num_packets, int packet_size, int interval,

	      usb_complete_t complete, void *context)
@@ -1720,7 +1720,7 @@ hfcsusb_stop_endpoint(struct hfcsusb *hw, int channel) 




/* Hardware Initialization */

int

static int

setup_hfcsusb(struct hfcsusb *hw)

{

	int err;

drivers/isdn/hardware/mISDN/hfcsusb.h

+3 −3
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ validconf[][19] = { 
};



/* string description of chosen config */

char *conf_str[] = {

static char *conf_str[] = {

	"4 Interrupt IN + 3 Isochron OUT",

	"3 Interrupt IN + 3 Isochron OUT",

	"4 Isochron IN + 3 Isochron OUT",
@@ -316,7 +316,7 @@ struct hfcsusb_vdata { 
#define HFC_MAX_TE_LAYER1_STATE 8

#define HFC_MAX_NT_LAYER1_STATE 4



const char *HFC_TE_LAYER1_STATES[HFC_MAX_TE_LAYER1_STATE + 1] = {

static const char *HFC_TE_LAYER1_STATES[HFC_MAX_TE_LAYER1_STATE + 1] = {

	"TE F0 - Reset",

	"TE F1 - Reset",

	"TE F2 - Sensing",
@@ -328,7 +328,7 @@ const char *HFC_TE_LAYER1_STATES[HFC_MAX_TE_LAYER1_STATE + 1] = { 
	"TE F8 - Lost framing",

};



const char *HFC_NT_LAYER1_STATES[HFC_MAX_NT_LAYER1_STATE + 1] = {

static const char *HFC_NT_LAYER1_STATES[HFC_MAX_NT_LAYER1_STATE + 1] = {

	"NT G0 - Reset",

	"NT G1 - Deactive",

	"NT G2 - Pending activation",