Commit 6c0e7284 authored Oct 09, 2017 by Steffen Klassert Committed by David S. Miller Oct 09, 2017

ipv4: Fix traffic triggered IPsec connections.



A recent patch removed the dst_free() on the allocated
dst_entry in ipv4_blackhole_route(). The dst_free() marked the
dst_entry as dead and added it to the gc list. I.e. it was setup
for a one time usage. As a result we may now have a blackhole
route cached at a socket on some IPsec scenarios. This makes the
connection unusable.

Fix this by marking the dst_entry directly at allocation time
as 'dead', so it is used only once.

Fixes: b838d5e1 ("ipv4: mark DST_NOGC and remove the operation of dst_free()")
Reported-by: Tobias Brunner <tobias@strongswan.org>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 62cf27e5

net/ipv4/route.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2513,7 +2513,7 @@ struct dst_entry ipv4_blackhole_route(struct net net, struct dst_entry *dst_or
		struct rtable ort = (struct rtable ) dst_orig;
		struct rtable *rt;

		rt = dst_alloc(&ipv4_dst_blackhole_ops, NULL, 1, DST_OBSOLETE_NONE, 0);
		rt = dst_alloc(&ipv4_dst_blackhole_ops, NULL, 1, DST_OBSOLETE_DEAD, 0);
		if (rt) {
		struct dst_entry *new = &rt->dst;