Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b6d24b3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Chris Mason
Browse files

Btrfs, scrub: uninitialized variable in scrub_extent_for_parity()



The only way that "ret" is set is when we call scrub_pages_for_parity()
so the skip to "if (ret) " test doesn't make sense and causes a static
checker warning.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent 4e0c4a47
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -2607,9 +2607,9 @@ static int scrub_extent_for_parity(struct scrub_parity *sparity,
		ret = scrub_pages_for_parity(sparity, logical, l, physical, dev,
		ret = scrub_pages_for_parity(sparity, logical, l, physical, dev,
					     flags, gen, mirror_num,
					     flags, gen, mirror_num,
					     have_csum ? csum : NULL);
					     have_csum ? csum : NULL);
skip:
		if (ret)
		if (ret)
			return ret;
			return ret;
skip:
		len -= l;
		len -= l;
		logical += l;
		logical += l;
		physical += l;
		physical += l;