Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6af8df4c authored by Zhiyong Tao's avatar Zhiyong Tao Committed by Linus Walleij
Browse files

pintcrl: mtk: support bias-disable of generic and special pins simultaneously 



For generic pins, parameter "arg" is 0 or 1.
For special pins, bias-disable is set by R0R1,
so we need transmited "00" to set bias-disable
When we set "bias-disable" as high-z property,
the parameter should be "MTK_PUPD_SET_R1R0_00".

Signed-off-by: default avatarZhiyong Tao <zhiyong.tao@mediatek.com>
Reviewed-by: default avatarSean Wang <sean.wang@mediatek.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 8670710f

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+6 −2
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, 
		unsigned int pin, bool enable, bool isup, unsigned int arg)

{

	unsigned int bit;

	unsigned int reg_pullen, reg_pullsel;

	unsigned int reg_pullen, reg_pullsel, r1r0;

	int ret;



	/* Some pins' pull setting are very different,
@@ -301,8 +301,12 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, 
	 * resistor bit, so we need this special handle.

	 */

	if (pctl->devdata->spec_pull_set) {

		/* For special pins, bias-disable is set by R1R0,

		 * the parameter should be "MTK_PUPD_SET_R1R0_00".

		 */

		r1r0 = enable ? arg : MTK_PUPD_SET_R1R0_00;

		ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin),

			pin, pctl->devdata->port_align, isup, arg);

			pin, pctl->devdata->port_align, isup, r1r0);

		if (!ret)

			return 0;

	}