Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ad22dc9 authored by Dinghao Liu's avatar Dinghao Liu Committed by Greg Kroah-Hartman
Browse files

ext4: fix error handling code in add_new_gdb 



commit c9e87161cc621cbdcfc472fa0b2d81c63780c8f5 upstream.

When ext4_journal_get_write_access() fails, we should
terminate the execution flow and release n_group_desc,
iloc.bh, dind and gdb_bh.

Cc: stable@kernel.org
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: default avatarAndreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20200829025403.3139-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 314b5a46

fs/ext4/resize.c

+3 −1
Original line number Diff line number Diff line
@@ -861,8 +861,10 @@ static int add_new_gdb(handle_t *handle, struct inode *inode, 


	BUFFER_TRACE(dind, "get_write_access");

	err = ext4_journal_get_write_access(handle, dind);

	if (unlikely(err))

	if (unlikely(err)) {

		ext4_std_error(sb, err);

		goto errout;

	}



	/* ext4_reserve_inode_write() gets a reference on the iloc */

	err = ext4_reserve_inode_write(handle, inode, &iloc);