Commit 6a2cf55d authored Jul 06, 2016 by Wei Yongjun Committed by Vinod Koul Jul 12, 2016

dmaengine: qcom_hidma: fix return value check in hidma_mgmt_of_populate_channels()



In case of error, the function platform_device_register_full()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent d3183447

drivers/dma/qcom/hidma_mgmt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -371,8 +371,8 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
		pdevinfo.size_data = 0;
		pdevinfo.dma_mask = DMA_BIT_MASK(64);
		new_pdev = platform_device_register_full(&pdevinfo);
		if (!new_pdev) {
		ret = -ENODEV;
		if (IS_ERR(new_pdev)) {
		ret = PTR_ERR(new_pdev);
		goto out;
		}
		of_dma_configure(&new_pdev->dev, child);