Commit 69cbc046 authored May 30, 2013 by Chen Gang Committed by Tony Luck Jun 03, 2013

[IA64] hpsim: Fix check for overlong simscsi prefix.



When "strlen(s) > MAX_ROOT_LEN", it has already said to use the default
value, but in fact, it still use the input value.

If happens, next sprintf() for 'fname' in simscsi_queuecommand_lck()
may be memory overflow.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent d5e660ba

arch/ia64/hp/sim/simscsi.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -88,7 +88,7 @@ simscsi_setup (char *s)
	if (strlen(s) > MAX_ROOT_LEN) {		if (strlen(s) > MAX_ROOT_LEN) {
	printk(KERN_ERR "simscsi_setup: prefix too long---using default %s\n",		printk(KERN_ERR "simscsi_setup: prefix too long---using default %s\n",
	simscsi_root);		simscsi_root);
	}		} else
	simscsi_root = s;		simscsi_root = s;
	return 1;		return 1;
	}		}