Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69c80f3e authored by Venkatesh Pallipadi's avatar Venkatesh Pallipadi Committed by Ingo Molnar
Browse files

sched: Make set_*_buddy() work on non-task entities 



Make set_*_buddy() work on non-task sched_entity, to facilitate the
use of next_buddy to cache a group entity in cases where one of the
tasks within that entity sleeps or gets preempted.

set_skip_buddy() was incorrectly comparing the policy of task that is
yielding to be not equal to SCHED_IDLE. Yielding should happen even
when task yielding is SCHED_IDLE. This change removes the policy check
on the yielding task.

Signed-off-by: default avatarVenkatesh Pallipadi <venki@google.com>
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1302744070-30079-2-git-send-email-venki@google.com


Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 6ddafdaa

kernel/sched_fair.c

+12 −12
Original line number Diff line number Diff line
@@ -1846,27 +1846,27 @@ wakeup_preempt_entity(struct sched_entity *curr, struct sched_entity *se) 


static void set_last_buddy(struct sched_entity *se)

{

	if (likely(task_of(se)->policy != SCHED_IDLE)) {

	if (entity_is_task(se) && unlikely(task_of(se)->policy == SCHED_IDLE))

		return;



	for_each_sched_entity(se)

		cfs_rq_of(se)->last = se;

}

}



static void set_next_buddy(struct sched_entity *se)

{

	if (likely(task_of(se)->policy != SCHED_IDLE)) {

	if (entity_is_task(se) && unlikely(task_of(se)->policy == SCHED_IDLE))

		return;



	for_each_sched_entity(se)

		cfs_rq_of(se)->next = se;

}

}



static void set_skip_buddy(struct sched_entity *se)

{

	if (likely(task_of(se)->policy != SCHED_IDLE)) {

	for_each_sched_entity(se)

		cfs_rq_of(se)->skip = se;

}

}



/*

 * Preempt the current task with a newly woken task if needed: