Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 699fbeea authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/fb-helper: Fix sparse warnings 



drm/drm_fb_helper.c:2306:12: warning: symbol 'drm_fb_helper_modinit' was not declared. Should it be static?

While at it, move the lefover static inline to the right place.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1474292035-15695-4-git-send-email-ville.syrjala@linux.intel.com
parent c30b4400

drivers/gpu/drm/drm_crtc_helper_internal.h

+7 −0
Original line number Diff line number Diff line
@@ -29,7 +29,14 @@ 
#include <drm/drm_dp_helper.h>



/* drm_fb_helper.c */

#ifdef CONFIG_DRM_FBDEV_EMULATION

int drm_fb_helper_modinit(void);

#else

static inline int drm_fb_helper_modinit(void)

{

	return 0;

}

#endif



/* drm_dp_aux_dev.c */

#ifdef CONFIG_DRM_DP_AUX_CHARDEV

drivers/gpu/drm/drm_fb_helper.c

+2 −0
Original line number Diff line number Diff line
@@ -41,6 +41,8 @@ 
#include <drm/drm_atomic.h>

#include <drm/drm_atomic_helper.h>



#include "drm_crtc_helper_internal.h"



static bool drm_fbdev_emulation = true;

module_param_named(fbdev_emulation, drm_fbdev_emulation, bool, 0600);

MODULE_PARM_DESC(fbdev_emulation,

include/drm/drm_fb_helper.h

+0 −5
Original line number Diff line number Diff line
@@ -287,11 +287,6 @@ int drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, struct drm_ 
int drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper,

				       struct drm_connector *connector);

#else

static inline int drm_fb_helper_modinit(void)

{

	return 0;

}



static inline void drm_fb_helper_prepare(struct drm_device *dev,

					struct drm_fb_helper *helper,

					const struct drm_fb_helper_funcs *funcs)