Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68f37e5d authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Kalle Valo
Browse files

wlcore: fix error handling in wlcore_event_fw_logger 

wlcore_read/wlcore_write can return negative values so it should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2120705



Fixes: 3719c17e ("wlcore/wl18xx: fw logger over sdio")
Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 17934b6a

drivers/net/wireless/ti/wlcore/event.c

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ 


int wlcore_event_fw_logger(struct wl1271 *wl)

{

	u32 ret;

	int ret;

	struct fw_logger_information fw_log;

	u8  *buffer;

	u32 internal_fw_addrbase = WL18XX_DATA_RAM_BASE_ADDRESS;